joplin icon indicating copy to clipboard operation
joplin copied to clipboard

Not enought contrast in Aritim Dark: Horizontal Rule and Inline Code are hard to read/see

Open Elaborendum opened this issue 3 years ago • 36 comments

When writing something as inline code in the Aritim Dark theme, it's written in a barely visible dark green. (ignore the red line, I'm using a spell checker in another language)

Same thing happens if you create a horizontal rule, but this time both on Markdown and WYSIWYG view

Aritim Dark: image

Regular Dark: image

Horizontal Rule in Markdown view: imagen

Horizontal Rule in WYSIWYG view: imagen

Environment

Joplin version: 1.8.5-2.3.5 Platform: Windows OS specifics: Windows 10

Steps to reproduce

  1. Change theme to Aritim Dark
  2. Write something as inline code or create a horizontal rule
  3. See the low contrast

Describe what you expected to happen

Text/rule should be easier to read.

Elaborendum avatar May 23 '21 16:05 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

stale[bot] avatar Jun 22 '21 16:06 stale[bot]

Issue is still present.

Elaborendum avatar Jun 22 '21 17:06 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

stale[bot] avatar Jul 22 '21 23:07 stale[bot]

Issue is still present.

Elaborendum avatar Jul 23 '21 00:07 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

stale[bot] avatar Aug 22 '21 17:08 stale[bot]

Issue is still present.

Elaborendum avatar Aug 22 '21 23:08 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

stale[bot] avatar Sep 22 '21 00:09 stale[bot]

Issue is still present.

Elaborendum avatar Sep 22 '21 01:09 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

stale[bot] avatar Nov 09 '21 20:11 stale[bot]

Issue is still present.

Elaborendum avatar Nov 11 '21 02:11 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Jan 09 '22 00:01 github-actions[bot]

Issue is still present.

Elaborendum avatar Jan 09 '22 12:01 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Feb 09 '22 16:02 github-actions[bot]

Issue is still present.

Elaborendum avatar Feb 09 '22 16:02 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Mar 13 '22 16:03 github-actions[bot]

Issue is still present.

Elaborendum avatar Mar 13 '22 16:03 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Apr 14 '22 16:04 github-actions[bot]

Issue is still present.

Elaborendum avatar Apr 14 '22 16:04 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar May 16 '22 16:05 github-actions[bot]

Issue is still present.

Elaborendum avatar May 16 '22 21:05 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Jun 17 '22 16:06 github-actions[bot]

Issue is still present.

Elaborendum avatar Jun 17 '22 16:06 Elaborendum

+1 all dark themes are hard to recognize inline code and code block.

image

calfzhou avatar Jul 06 '22 08:07 calfzhou

+1 all dark themes are hard to recognize inline code and code block.

What theme is that? I just went through all the dark themes and none of the code blocks appear like that for me. Are you using any custom CSS?

Daeraxa avatar Jul 06 '22 09:07 Daeraxa

I'm using Joplin for Desktop 2.8.8 on Mac OS.

It's strange. I reinstalled the desktop app, now it looks good. I guess it might caused by the macOS theme plugin, but not very sure. I did't use any custom themes.

Joplin 2.8.8 (prod, darwin)

Client ID: c7186efe5a5643a38d4b546e5a3a3663 Sync Version: 3 Profile Version: 41 Keychain Supported: Yes

Revision: c2a6a13

+1 all dark themes are hard to recognize inline code and code block.

What theme is that? I just went through all the dark themes and none of the code blocks appear like that for me. Are you using any custom CSS?

calfzhou avatar Jul 06 '22 09:07 calfzhou

Ah, I find the root cause. When i use Source Code Pro font for monospace, the color changes ... Now I removed custom font setting.

calfzhou avatar Jul 06 '22 09:07 calfzhou

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Aug 05 '22 16:08 github-actions[bot]

Issue is still present.

Elaborendum avatar Aug 06 '22 02:08 Elaborendum

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar Sep 06 '22 16:09 github-actions[bot]

Issue is still present.

Elaborendum avatar Sep 07 '22 19:09 Elaborendum