joplin
joplin copied to clipboard
laurent22
Dark mode not respected by "Sort notes by"
Environment
Joplin version: 1.7.5, Database v34, FTS enabled: 1 Platform: Android OS specifics: 10
Steps to reproduce
- Configuration -> Appearance -> Theme -> OLED Dark
- Darkness appears
- Back to start-screen
- Tap 3-horisontal-line menu-button top right
- White background
Describe what you expected to happen
Dark background
Logfile
No errors in Configuration -> Log
@roman-r-m I wish to work on this. I am a beginner. Can you let me know the location of theme files in your codebase ?
I suppose it's https://github.com/laurent22/joplin/blob/ccbc329cbf806e9b6db6d37f8c837629ee6c3a60/packages/lib/theme.ts
@roman-r-m So i checked this. Turns out that the sort dialog does not obey any of the themes for mobile app only. Whereas for desktop app, the sort option obeys theme rules. So, it looks that perhaps the element has been created differently for mobile app. I am not well versed with android app development so could you please guide me how the sort dialog is formed for joplin mobile app?
the element has been created differently for mobile app
Probably, yes. Most UI elements are different between desktop and mobile.
I am not well versed with android app development so could you please guide me how the sort dialog is formed for joplin mobile app?
What have you tried so far? A simple search for "sort" in packages/app-mobile should give you the result.
Related: Same with prompt "Delete these notes?"
Possibly related: https://github.com/laurent22/joplin/issues/4450
Possibly related: Long-press in a note does not respect system's dark-mode (for popup of e.g. "Paste" and "Select all")
Thanks for taking on the issue, and tell me if these are not related, and should be separate issues instead. =)
If I recall correctly, the long-press & "delete these notes" dialogs are the same component, and it's different from the one used for the sort order (i.e. this issue).
@roman-r-m there seems to be many issues with themes in mobile app. It seems they will need to be redesigned for mobile app keeping other components in mind. I am unable to find the any sort component in the app-mobile folder. My knowledge is limited and I am new to the codebase
there seems to be many issues with themes in mobile app. It seems they will need to be redesigned for mobile app keeping other components in mind.
While I do agree that UI on mobile is sometimes inconsistent (and plain ugly at times), what's your suggestion? If you'd like to redesign all of it, this might be too much for the 1st task. Otherwise, if you don't want to fix this issue, you're free to pick something else.
I am unable to find the any sort component in the app-mobile folder. My knowledge is limited and I am new to the codebase
Again, what have you tried to find it? Keep in mind, there may not be a separate component, might be a part of a bigger UI element.
@roman-r-m so i did some digging around and i was able to find:
- The sort functionality for the app: https://github.com/laurent22/joplin/blob/35063ac05cfb3735caa193a4eb2760c42337c5da/packages/app-mobile/components/screen-header.js#L322
- The sortButtonPress function: https://github.com/laurent22/joplin/blob/35063ac05cfb3735caa193a4eb2760c42337c5da/packages/app-mobile/components/screens/notes.js#L35
Will take me some time but i am positive i will fix it in a few days.
I have connected my phone via USB for debugging but still getting this error:
warn No apps connected. Sending "devMenu" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.
Moreover running into errors while building from android studio. Is there a development guide for building the mobile app?
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Still requires the community's attention
Joplin 2.6.8 - Database v41
@laurent22 Poke. :)
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.