joplin
joplin copied to clipboard
laurent22
No way to search from inside a note on Android
There is no way to search for text in a note from inside the note view on Android. Desktop versions of Joplin provide this functionality, but not on Android. There are previous issues describing this problem that were automatically closed (see #382).
As I understand, b189814 adds an ability to highlight the text within notes, so one can search from the main note search menu, but this is useless and using this function is not intuitive when a user is already inside a note.
The open menu on the screenshot should contain another option to "Search in this note".
Environment
Joplin version: 1.0.316 Platform: Android
Mentors please review my PR #2423 and let me know if it requires any changes. @tessus @CalebJohn @laurent22
@laurent22 can you please help me with this, I tried to forceUpdate the component based on props changes but does not work, also I created ref for the webview and thought to refresh whenever search keyword props changes but still the highlight was not working do you have a suggestion for me
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Searching in long notes is quite essential, both in the Android and desktop client.
I would like to work on this. @tessus can you please assign this issue to me?
I have added a 'Search in this note' button to the side menu, I'm trying to figure out a way to get text input from the user. Can anyone help me with this, I'm planning to use some sort of custom alert to get input from the user?
@Pilastr I dont think i'd be able to finish it since it would require a significant amount of code writing.
@dbogdanov @laurent22 I would like to work on this issue. Is anyone assigned yet or I can work on it?
It's not on GSoC, and I'm not certain it can be done due to the buggy text input control (broken selection API, and I doubt scrolling is much better).
It's not on GSoC, and I'm not certain it can be done due to the buggy text input control (broken selection API, and I doubt scrolling is much better).
@laurent22 Okay thanks. I will try to look into the codebase if i can do something. Can you suggest some bugs that i can solve that can be related to GSoC. Thanks.
Looking at the CodeMirror 6 basic-setup plugin and the CodeMirror 6 documentation, it looks like we can show/hide the existing search panel if we enable it! This would only apply to the beta editor, though...
Looking at the CodeMirror 6 basic-setup plugin and the CodeMirror 6 documentation, it looks like we can show/hide the existing search panel if we enable it! This would only apply to the beta editor, though...
Indeed that would be a great solution if we can simply rely on the built-in search.
I want to add my vote for being able to search while viewing an individual note. I found a discussion that searching within a single note is available if I edit the note. Indeed, that does work. But this is not ideal. I spend more time viewing notes than I do editing them (thankfully.) So being able to search a note in view mode would be very helpful.
