joplin icon indicating copy to clipboard operation
joplin copied to clipboard

Recorded location is vague

Open metafarion opened this issue 1 year ago • 8 comments

Operating system

Android

Joplin version

3.0.2

Current behaviour

The geo-location data on notes created on my phone doesn't seem to be very precise. It has correctly identified my city, but nothing else. I'm running a Pixel 6 with Android 14

Expected behaviour

When granted Precise Location permissions, shouldn't the GPS be used to derive my exact location? It seems to only be using my IP.

Logs

No response

metafarion avatar Apr 22 '24 16:04 metafarion

When you create a new note, is there any information regarding geo-location in the log? I believe it should indeed only use the phone GPS for this and should be precise, but maybe there's an error. You can find the log info as described here: https://joplinapp.org/debugging

laurent22 avatar Apr 22 '24 16:04 laurent22

Hmmm, this is peculiar. I'm not sure what has changed since my prior tests, but now my location is being reported as somewhere in France. Looking at the App Permissions for Joplin in the android settings, I can reconfirm that it has location permissions, though curiously it says last accessed over an hour ago. So my current tests do not even seem to be trying to use the GPS, but are still attaching some kind of default location. I dug through the logs a bit, and I can see the lines for "fetching geolocation" "Got lat/long" "Updating lat/long of note" for each note, but no errors in their vicinity.

metafarion avatar Apr 22 '24 17:04 metafarion

Where in France exactly? and are you not in France? Also where did you get this app version from?

laurent22 avatar Apr 22 '24 17:04 laurent22

Oh sorry, no I'm in the US. But the location 48.73219094, -3.45966339 is now being assigned to every note I create on my phone. This version of Joplin is from FDroid

metafarion avatar Apr 22 '24 17:04 metafarion

Oh sorry, no I'm in the US. But the location 48.73219094, -3.45966339 is now being assigned to every note I create on my phone. This version of Joplin is from FDroid

That's the location used in a dev environment which means your app somehow is in dev mode. Unless we made a mistake somewhere it seems it's F-Droid that's publishing a dev version of the app so you might want to let them know. We don't manage this particular distribution.

laurent22 avatar Apr 22 '24 18:04 laurent22

Alright, so after some discussion with the F-Droid people, it turns out the geolocation problem is a consequence of them not wanting any FOSS software or dependencies in their repository at all. Specifically in this case, it's an objection to the use of Google location services: https://gitlab.com/fdroid/fdroiddata/-/issues/3248#note_1876008277

So this might be a show-stopper for the F-Droid version of Joplin, but I thought you should be aware if you aren't already, and perhaps there is a FOSS geolocation method that could be used instead, though I understand that's probably a good deal more work.

metafarion avatar Apr 23 '24 17:04 metafarion

Thanks for looking into this, that's good to know. I guess they patched this part of the code then and probably the easiest way was to make it follow the dev code path.

I guess we could make it fallback to use an IP-based geolocation like on desktop but that would require some extra work which I'm not sure is worth it. If someone is willing to create a PR for it though I'd be ok with it

laurent22 avatar Apr 23 '24 17:04 laurent22

Specifically in this case, it's an objection to the use of Google location services:

not quite true actually :), it's not a matter of services but of libs used to access whose services, and those libs are themselves or depend on other libs that are non-FOSS.

licaon-kter avatar Apr 24 '24 10:04 licaon-kter

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

github-actions[bot] avatar May 24 '24 16:05 github-actions[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.

github-actions[bot] avatar May 31 '24 16:05 github-actions[bot]