Menu bar undo and redo options doesn't work when new line is inserted.

[ab-elhaddad]

Operating system

Windows

Joplin version

3.0.2

Desktop version info

Joplin 3.0.2 (dev, win32)

Client ID: 8a192868cad6461aa4b81f41e9b0f5d9 Sync Version: 3 Profile Version: 46 Keychain Supported: Yes

Revision: 06aa64016 (dev)

Backup: 1.4.1 BibTeX: 0.5.0 Delete notes without confirmation: 1.0.0 Rich Markdown: 0.13.4

Current behaviour

The undo and redo options in the window menu bar don't work when a new line is inserted although the ctrl+z and ctrl+shift+z work. the undo and redo only work on the first line of the note.

This is a video producing the issue.

https://github.com/laurent22/joplin/assets/113056556/52869c16-1737-431d-9fce-09a226f048de

I think it's a bug from the electron framework, as we use the built-in undo and redo actions in electron.

Code Snippet from Menu.tsx

// Using the generic "undo"/"redo" roles mean the menu
// item will work in every text fields, whether it's the
// editor or a regular text field.
{
	role: 'undo',
	label: _('Undo'),
},
{
	role: 'redo',
	label: _('Redo'),
},

So, we may disable them or implement our undo and redo functionalities and override them.

#9584 Related issue.

Expected behaviour

undo and redo options should work on all lines like the ctrl+z and ctrl+shift+z

Logs

No response

[DarkFalc0n]

I couldn't recreate this in my Arch Linux system, the undo and redo buttons are working for me. Im using an older version, 2.14.20

[ab-elhaddad]

It doesn't work either in version 2.14.20. But I am using Windows in both versions, so it may be a Windows-related bug.

https://github.com/laurent22/joplin/assets/113056556/3765eacc-0187-40b4-980f-96697d0871ea

[khalidkhankakar]

{ role: 'undo', label: _('Undo'), // Assign the handleUndo function to the click event of the menu item click: handleUndo }, { role: 'redo', label: _('Redo'), // Assign the handleRedo function to the click event of the menu item click: handleRedo }

I think it wil work when we pass function to this like handleUndo and handleRedo

[github-actions[bot]]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

[github-actions[bot]]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.