joplin
joplin copied to clipboard
Desktop: Resolves #9998: Fixed text wrapping in Specllcheck button
Description
Fixed https://github.com/laurent22/joplin/issues/9998 using one liner.
Screenshots
Before:
After:
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
Now that I see the screenshot... Is it possible to instead cut the text with an ellipsis?
Will try to do so and get back to you.
I tried the following css but the text won't truncate without setting a specific value to the width, which then wont show the full text even when you expand it. Will try it out some more, any ideas?
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
display: block;
Edit: I've found some references: https://css-tricks.com/flexbox-truncated-text/
Edit 2: Got a working solution now! Is this acceptable?
I had to wrap text inside the ToolbarButtons with a span, otherwise it wouldn’t truncate with ellipsis, it just truncated from both sides.
Also apologies if I do this wrong but @PackElend label me please (Do I ask for this label after creating future PRs as well?).
(Do I ask for this label after creating future PRs as well?)
yes, otherwise we cannot track your work