Laurent Cozic
Laurent Cozic
So should we wait before merging this?
Thanks for creating this change. It needs to have the same quality of validation as the slider since we don't want invalid values to get in. As personalizedrefrigerator mentioned I'd...
> @laurent22 could you clarify if by "quality of validation" you just mean that is needs to prevent invalid values getting in, or also the fact that for the TextInput...
> @laurent22 Is there any chance of this cut down code change getting merged? Note history and trash ttl are pretty much set and forget, so not a big deal...
Any chance test units could be added for this? It's scary that no tests failed when the previous change was committed.
If you look at `Synchronizer.revisions.test.ts` it's doing something close to integration tests with simulation of sync between clients. It's something like this we would need
Yes that looks good, thank you for implementing this @mrjo118!
I cannot replicate this
Any additional errors in the console?
Any chance you could share a minimal example that replicates the issue?