Laurent Cozic

Results 266 comments of Laurent Cozic

Tests are failing: https://github.com/laurent22/joplin/runs/7729267796?check_suite_focus=true#step:10:4324

Unfortunately still a yarn.lock conflict. A new one this time.

Ok I've tested it on simulator and it looks good, thanks Tolu!

I don't think we'll support URLs as those can changed (in fact I'm surprised Chome supports this). We wouldn't want someone to swap the URL content for malware or something...

Let's not support videos for now. And use this structure: "screenshots": [ { "src": "path/to/image.png", "label": "Image description" }, For now we only have the src and label properties.

Ok thank you, looks like it's ready to merge.

I believe this is also fixed in 6a4eb3309396f1a2a1a979b1a07a82ad9f9c2c57

Is that a common thing to support multiple languages? Do you have any example of app that supports this?

Brilliant, thanks for checking @personalizedrefrigerator. I was wondering if there was a better way to support multiple languages, such as per-note language, but if it's common to have this it...

> The change that I don't feel great about is this hack to the setting parser, so it can change currently stored string to the array. We have an object...