Laurent Cozic

There's also the issue of long term maintenance. If you use concatenated queries, even if correctly escaped, future developers are more likely to make mistakes. There's a discussion about it...

Yes there are false positives (and negatives). For performance reason, the script uses regular expressions, which provide a good enough approximation, but indeed aren't perfect. Also the script can't determine...

I'm not sure there's a huge difference between a "potential one" and "real one" actually. Something like `delete from students where email = " . $email` is a vulnerability, not...

I wonder if that could be made optional, perhaps with a warning? When processing an entire codebase with eslint it would be useful if require or import statements were auto-removed....

Hmm, yes maybe now that WSL can support multiple Linux images, this trick won't work properly. Thanks anyway for sharing in case it helps somebody.

I hope that could be fixed too. A simple package shouldn't crash the whole app when something goes wrong. Ideally it should throw an error but even returning null would...

Just so you know the doc for your custom fork [here](https://www.npmjs.com/package/@seiyab/eslint-plugin-react-hooks) is wrong. It should be: ``` { "plugins": [ // ... "@seiyab/eslint-plugin-react-hooks" ], "rules": { // ... "@seiyab/react-hooks/rules-of-hooks": "error",...

Appears to be fixed (maybe by #6326 ?). When the app is using the dark theme, the keyboard is also dark.

- How about we display only one icon, the "syncing" one when the state is "needs sync" and "syncing"? I feel it's too much information going on otherwise whenever a...

> Maybe the icon should only show when there is a background/initial sync going on? I thought about that too, but it may also be distracting with the icon constantly...