sheepit-client icon indicating copy to clipboard operation
sheepit-client copied to clipboard

Published 20 hours ago • verified publisher icon laurent-clouet

Removing unused imports.

Open webii opened this issue 5 years ago • 2 comments

Isolating classes from giving too much access to private properties (removing @Data). Removing unused visibility options from interface. Moving some classes to specific packages.

webii avatar Oct 11 '20 17:10 webii

When PRing such a large batch of changes, usually you'd provide a reason (even if you think the reason is obvious). Also, it is better to create 4 PRs for 4 changes, not 1 massive Code Cleanup PR. Finally, please adjust your title, it's misleading.

MCOfficer avatar Oct 11 '20 17:10 MCOfficer

I were able to build the client and run it. So it could be fine.

Raimund58 avatar Oct 20 '20 07:10 Raimund58