bevy-spatial icon indicating copy to clipboard operation
bevy-spatial copied to clipboard

Add "within" support (rectangular axis-alligned region).

Open VitalyArtemiev opened this issue 2 years ago • 4 comments

Issue https://github.com/laundmo/bevy-spatial/issues/7 Example in distance2d.rs.

VitalyArtemiev avatar Oct 11 '23 01:10 VitalyArtemiev

Hi!

Thank you a lot for your PR.

i'm a bit wary about expanding the SpatialAccess Trait like this - other data structures, of which i plan to add at least 2 somewhere during the next bevy release cycle, might not support it.

How do you feel about moving that to a extension trait? It would mean users have to import another trait, but leaves the option for other datastructures which don't support it.

laundmo avatar Oct 13 '23 19:10 laundmo

Of course, if you think it's best. I'll try implementing it that way.

VitalyArtemiev avatar Oct 13 '23 19:10 VitalyArtemiev

I finally got around to it. Hope this is what you had in mind.

VitalyArtemiev avatar Apr 02 '24 01:04 VitalyArtemiev

@laundmo can we get this merged?

cliedelt avatar Sep 23 '24 18:09 cliedelt