sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Document code of `sqlx::query_as` has bugs.

Open xuehaonan27 opened this issue 1 year ago • 2 comments

Bug Description

In the document example code of sqlx::query_as, there exists several bugs that I encountered when testing. query_as.rs: 230 mismatched bracket. query_as.rs: 230 move TIMESTAMP to TIMESTAMPTZ to match type time::OffsetDateTime. query_as.rs: 241, 251, 260 move i64 to i32 to match postgres type INT4.

Minimal Reproduction

Just run current code piece in document of query_as: https://docs.rs/sqlx/latest/sqlx/fn.query_as.html#example-map-rows-using-tuples

Info

  • SQLx version: 0.8.2
  • SQLx features enabled: "runtime-tokio", "postgres", "time"
  • Database server and version: psql (PostgreSQL) 14.13 (Homebrew)
  • Operating system: MacOS Sonoma 14.5 23F79
  • rustc --version: rustc 1.81.0 (eeb90cda1 2024-09-04)

xuehaonan27 avatar Oct 11 '24 16:10 xuehaonan27

I believe the Json example using query_as is also incorrect. It looks like macro returns Option<Json<T>> instead of Json<T> and Json<T> doesn't implement From<Option<Json<T>>>

https://docs.rs/sqlx/latest/sqlx/types/struct.Json.html

benbot avatar Oct 11 '24 21:10 benbot

I believe the Json example using query_as is also incorrect. It looks like macro returns Option<Json<T>> instead of Json<T> and Json<T> doesn't implement From<Option<Json<T>>>

https://docs.rs/sqlx/latest/sqlx/types/struct.Json.html

I will check it as well! Thank you very much!

xuehaonan27 avatar Oct 12 '24 05:10 xuehaonan27