sqlx
sqlx copied to clipboard
Removed `Send` trait bound from argument binding
Initial PR that removes all the Send
trait bounds from various argument binding methods. While the argument buffer makes sense to be Send
as it might be passed around, arguments passed in are immediately encoded away, so it does not seem to be required for them to be Send
.
The PR could be expanded to add an Encode
impl for std::fmt::Arguments
(the initial motivation for removing the bounds) and even make the Text
adapter rely on it when getting encoded.
Fixes #2959
If you rebase, it should hopefully fix the error.
I don't disagree with removing the Send
bound but it is a breaking change to the Arguments
trait.
If you rebase, it should hopefully fix the error.
I don't disagree with removing the
Send
bound but it is a breaking change to theArguments
trait.
What do you think about adding an Encode
impl for the std::fmt::Arguments
type?
You can just wrap fmt::Arguments
in Text()