sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Mention that MSSQL driver is not present in 0.7^ anymore

Open big-lip-bob opened this issue 1 year ago • 7 comments

Self explanatory, the readme still says that the MSSQL driver is present as a cargo feature flag, but its only present in pre 0.7. It'd be nicer if it was highlighted that it isn't the case since 0.7^.

big-lip-bob avatar Jul 31 '23 04:07 big-lip-bob

actually I think this was a really bad decision to remove mssql, it was working fine, just needed a little work on chrono compatibility, but authors want money now, right?

57r31 avatar Aug 10 '23 04:08 57r31

The old code is still around in the Git history so if you feel that there's just a little work necessary to improve it to the point where it's production-ready then feel free to maintain it yourself.

What's great is that the 0.7 release made it much easier to do that in a separate crate, which that means that someone like you who has the time to maintain support for closed-source database systems for free has nothing that prevents them from doing so. :)

kyrias avatar Aug 10 '23 09:08 kyrias

kyrias, @lovasoa already did that here https://github.com/lovasoa/sqlx/

57r31 avatar Aug 11 '23 04:08 57r31

Yes, I maintain a fork of sqlx that is still compatible with the 0.6 API, and contains security updates and bug fixes. I need it for SQLPage.

I published it as https://crates.io/crates/sqlx-oldapi

I made multiple improvements to the SQL Server driver, and it's being actively tested in the context of SQLPage.

I'll also include support for JSON serialization of Rows, which I currently maintain separately in SQLPage.

lovasoa avatar Aug 11 '23 04:08 lovasoa

Please please remove mentions in docs and the about section of the repo that mssql is supported. I love the library and as I wanted to apply it to something new at work and saw you explicitly stating in a multitude of locations you have support I assumed it was the case.

adaptive-alexander avatar Aug 19 '23 14:08 adaptive-alexander

Please please remove mentions in docs and the about section of the repo that mssql is supported. I love the library and as I wanted to apply it to something new at work and saw you explicitly stating in a multitude of locations you have support I assumed it was the case.

Second this. Went to use the project at work for something explicitly because mssql is mentioned as being supported in the readme. In an enterprise environment mssql is very very common and I think should be supported. I'm not aware of any of the background on this, so I don't know why the decision was made to remove it.

danwritecode avatar Jan 12 '24 18:01 danwritecode

@danwritecode I wrote a short post about that : https://sql.ophir.dev/blog.sql?post=I%E2%80%99m%20sorry%20I%20forked%20you

lovasoa avatar Jan 12 '24 22:01 lovasoa

OH! Please add MSSQL driver to new version SQLX! Thank you!.

zoujiaqing avatar Jul 24 '24 09:07 zoujiaqing

I think this issue can be closed, the mention has been added to the readme: https://github.com/launchbadge/sqlx/commit/4bac21da3709da91ff03d26fe3ed14459a36b854

lovasoa avatar Jul 24 '24 09:07 lovasoa