sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Feature/transaction options

Open xfbs opened this issue 3 years ago • 6 comments

I've stolen the code from #1827, implemented the suggestions and rebased it on top of the current main branch. Missing some unit tests for the Any-related code.

xfbs avatar Jun 22 '22 15:06 xfbs

@andrewwhitehead would you prefer to finish your PR or just see this one merged? I would credit you both in the changelog.

abonander avatar Jul 09 '22 00:07 abonander

I'm happy with merging this one, thanks!

andrewwhitehead avatar Jul 09 '22 00:07 andrewwhitehead

FYI, I've just rebased on top of the current main branch and pushed the changes. Hope I didn't break anything.

xfbs avatar Jul 18 '22 19:07 xfbs

PR target changed to the 0.7 development branch. @xfbs can you rebase again?

abonander avatar Sep 15 '22 00:09 abonander

I'll rebase this later today, iirc it's also missing some tests.

xfbs avatar Sep 15 '22 12:09 xfbs

@xfbs : I've rebased it already in my local temp branch: https://github.com/madadam/sqlx/commits/patches. Feel free to use it.

madadam avatar Sep 15 '22 12:09 madadam

Any updates? :)

billy1624 avatar Nov 16 '22 03:11 billy1624

@xfbs I finally finished my massive refactor, do you mind rebasing one more time?

abonander avatar Feb 02 '23 00:02 abonander

Hey Austin,

I can try! I have to say that I might need a little help with rebasing, since a lot of stuff has changed.

Cheers, Patrick

On Wed 1. Feb 2023 at 19:57, Austin Bonander @.***> wrote:

@xfbs https://github.com/xfbs I finally finished my massive refactor, do you mind rebasing one more time?

— Reply to this email directly, view it on GitHub https://github.com/launchbadge/sqlx/pull/1924#issuecomment-1412993337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF775AIN74WVGOIGX5UEMTWVMBATANCNFSM5ZQXLO5A . You are receiving this because you were mentioned.Message ID: @.***>

xfbs avatar Feb 02 '23 01:02 xfbs

Closing due to inactivity. Feel free to reopen if you get a chance to come back to this.

abonander avatar Mar 02 '23 01:03 abonander