pisces icon indicating copy to clipboard operation
pisces copied to clipboard

Not working when fish_vi_key_bindings is set

Open ubmit opened this issue 3 years ago • 11 comments

I've just installed the plugin using Fisher 4.1.0 and it simply doesn't work if fish_vi_key_bindings is set. It works perfectly when the default bindings are set, though. Is there any workaround?

ubmit avatar Dec 14 '20 22:12 ubmit

@guilhermedeandrade Are you seeing any errors like "test: Missing argument at index 2"? If you are, then it could be that $fish_key_bindings is not set at the time this runs:

https://github.com/laughedelic/pisces/blob/e45e0869855d089ba1e628b6248434b2dfa709c4/conf.d/pisces.fish#L1-L5

jorgebucaran avatar Dec 19 '20 04:12 jorgebucaran

I guess it is already set, because I have it in my config.fish file. Also: image

ubmit avatar Dec 19 '20 09:12 ubmit

Could you describe what didn't work exactly?

  1. What did you do?
  2. What actually happened?
  3. What did you expect to happen?

jorgebucaran avatar Dec 19 '20 10:12 jorgebucaran

As I said, it simply doesn't work. Nothing. It doesn't throw any error either.

  1. Installed the plugin using Fisher 4.1.0 and typed (, [ and ", but nothing autocloses.
  2. Nothing happened.
  3. I expected it to autoclose.

ubmit avatar Dec 19 '20 12:12 ubmit

@guilhermedeandrade What does echo $fish_key_bindings tell you?

jorgebucaran avatar Dec 31 '20 16:12 jorgebucaran

@guilhermedeandrade What does echo $fish_key_bindings tell you?

https://github.com/laughedelic/pisces/issues/29#issuecomment-748447295

fish_vi_key_bindings

ubmit avatar Jan 03 '21 08:01 ubmit

Could you try autopair.fish instead? I don't know what the problem could be with this plugin.

jorgebucaran avatar Jan 03 '21 09:01 jorgebucaran

Sure, will try it!

ubmit avatar Jan 04 '21 13:01 ubmit

autopair.fish doesn't work with fish_vi_key_bindings either

ubmit avatar Jan 04 '21 14:01 ubmit

@guilhermedeandrade Should be fixed now. 💯

jorgebucaran avatar Jan 04 '21 15:01 jorgebucaran

@guilhermedeandrade Should be fixed now. 💯

It works perfectly, thank you 🙏

ubmit avatar Jan 04 '21 17:01 ubmit