tzdata icon indicating copy to clipboard operation
tzdata copied to clipboard

Configurable download_url

Open austinsalonen opened this issue 5 years ago • 2 comments

Would you be opposed to a pull request moving the downlad_url value to config.exs?

We use this behind a firewall and can only get database updates with tzdata releases.

austinsalonen avatar Nov 12 '19 22:11 austinsalonen

Hi. I'm not opposed to that :)

lau avatar Nov 15 '19 01:11 lau

You mentioned you only get database updates with tzdata releases so you don't use the download functionality of tzdata? In that case, perhaps it's enough for you to disable the auto updater? https://github.com/lau/tzdata#automatic-data-updates

Or is there point that you do have an URL that you can hit to fetch the db, but it's not the default one?

How are you using other libraries that fetch data from somewhere (e.g. Hex). Do you use a proxy?

Just to be clear, I think customising the download url is a good idea because it gives extra flexibility (and makes it more testable) but I'm just trying to figure the exact use case.

wojtekmach avatar Nov 15 '19 10:11 wojtekmach