calecto icon indicating copy to clipboard operation
calecto copied to clipboard

ecto3 branch: Calecto.DateTime does not conform to Ecto 3.5 Ecto.Type behavior

Open baldwindavid opened this issue 5 years ago • 4 comments

Upgrading Ecto to 3.5 results in the following error when using the Calecto.DateTime type on the ecto3 branch...

** (UndefinedFunctionError) function Calecto.DateTime.equal?/2 is undefined or private, but the behaviour Ecto.Type expects it to be present

I've been using Calecto.DateTime for the past year without issue, but related tests fail upon upgrading to 3.5.

baldwindavid avatar Oct 15 '20 21:10 baldwindavid

If an example is of any use it appears that the cloak_ecto package just added support for ecto 3.5 in this PR... https://github.com/danielberkompas/cloak_ecto/pull/13

It is my assumption newer applications are solely using Calecto.DateTime. Is this something that should be pulled out into a separate standalone package?

baldwindavid avatar Oct 27 '20 15:10 baldwindavid

I'm also using the ecto3 branch and only for the Calecto.DateTime type. A fix or standalone package would be very welcome. Happy to help implement this if needed.

ClementineOldfield avatar Oct 28 '20 00:10 ClementineOldfield

@ClementineOldfield I'm personally thinking of waiting another couple weeks and then figuring out how to proceed. I've got a little bit of time before I have to upgrade, but don't want to be locked in pre-3.5 for too long. Also want to give @lau time in case he has specific plans or hopes for this library.

baldwindavid avatar Nov 02 '20 20:11 baldwindavid

hi!, I opened a PR with that support for missing callbacks, I hope this can help you, in our case with that changes all is running ok.

zgbjgg avatar Jan 27 '21 20:01 zgbjgg