mud icon indicating copy to clipboard operation
mud copied to clipboard

chore(indexer): add v2 api route, don't include schemas table by default

Open JamesLefrere opened this issue 10 months ago • 2 comments

Fixes #3386

  • Add an /api/2/logs route and deprecate the previous version (which remains in operation under the current route /api/logs for backwards compatibility)
  • Intentionally repeat the code verbatim (but without the unwanted filters) so that future modifications do not break third party uses of the v1 route.
  • Use the v2 api for logs in the indexer client
  • Always add the schemas table to the filters in createStoreSync, as this is no longer included by default in the indexer v2 api
  • Remove redundant filter for schemas table in getRecords
  • The only other instance of getting indexer logs that requires the schemas table—the public SQL API's getSnapshot—calls createStoreSync internally, so this can remain unchanged.

TODO

  • [x] Build and tests pass locally
  • [ ] Add e2e test
  • [ ] Test with example apps, ensure tables are created in different storage types

JamesLefrere avatar Jan 21 '25 10:01 JamesLefrere

⚠️ No Changeset found

Latest commit: ec4c0c0cd31c2f7dbd86cd0f13be2a84d9ca8638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 21 '25 10:01 changeset-bot[bot]

Could you use v2 instead of 2 in the url? ie: /api/v2/logs

ludns avatar Jan 21 '25 17:01 ludns