quda icon indicating copy to clipboard operation
quda copied to clipboard

Suspicious generator statement in lib/CMakeLists.txt [feature/generic_kernel]

Open bjoo opened this issue 4 years ago • 0 comments

There appears to be a suspicious generator statement in lib/CMakeLists.txt in [feature/generic_kernel] which looks like so:

# set up QUDA compile options
target_compile_definitions(
  quda PRIVATE $<$<CONFIG:DEVEL>:DEVEL> $<$<CONFIG:HOSTDEBUG>:HOST_DEBUG> $<$<CONFIG:DEVICEDEBUG>:DEVICE_DEBUG>
               $<$<CONFIG:DEBUG>:HOST_DEBUGDEVICE_DEBUG> $<$<CONFIG:SANITIZE>:HOST_DEBUG>)

The suspicious part is

$<$<CONFIG:DEBUG>:HOST_DEBUGDEVICE_DEBUG> 

which probably should be a list: HOST_DEBUG,DEVICE_DEBUG or HOST_DEBUG;DEVICE_DEBUG or some such. (The idea is DEBUG enables both HOST_DEBUG or DEVICE_DEBUG). If DEVICE_DEBUG is not turned on, trove is not disabled, and it appears to have bad interactions with device debugging causing some tests to fail.

Thanks to Corbin Robeck for reporting the issue with DEBUG

bjoo avatar Jan 12 '21 02:01 bjoo