rdd icon indicating copy to clipboard operation
rdd copied to clipboard

Replace all `..` with `...` instead

Open WaviestBalloon opened this issue 1 year ago • 4 comments

This PR replaces two dots in series with three instead as usually having a process log line would contain ... not ... Feel free to reject this PR if you preference it but it does hurt to look at.

For example:

[+] Extracting "content-configs.zip"..
[+] Extracted "content-configs.zip"! (Packages left: 19)

becomes:

[+] Extracting "content-configs.zip"...
[+] Extracted "content-configs.zip"! (Packages left: 19)

WaviestBalloon avatar Apr 18 '24 10:04 WaviestBalloon

Builds now fail. Bad PR.

bluepilledgreat avatar Apr 19 '24 17:04 bluepilledgreat

This PR also adds in a hidden backdoor.

bluepilledgreat avatar Apr 19 '24 17:04 bluepilledgreat

Builds now fail. Bad PR. This PR also adds in a hidden backdoor.

This is a feature

WaviestBalloon avatar Apr 19 '24 17:04 WaviestBalloon

DNLGTM

File size increased... 😠😡

AstonishedLiker avatar May 08 '24 21:05 AstonishedLiker

Opinionated(..) Denied!

2nd reason: refer to Liker https://github.com/latte-soft/rdd/pull/2#issuecomment-2101572660

chadhyatt avatar Jun 29 '24 01:06 chadhyatt

not to mention: refer to Matt https://github.com/latte-soft/rdd/pull/2#issuecomment-2067008464

chadhyatt avatar Jun 29 '24 01:06 chadhyatt

I believe this should be reconsidered. The implications of .. indicates that it is a fast pause rather than a long pause (...). Since @regginator's code is incredibly slow it would be more accurate to properly indicate the length using ... rather than ...

The file size loss is required to improve UX and there is no such backdoors in the provided pull request.

@latte-soft