latitude icon indicating copy to clipboard operation
latitude copied to clipboard

Migrate mysql connector to mysql2

Open geclos opened this issue 11 months ago • 2 comments

We currently use node's mysql package which is old and does not support some critical features from new mysql versions. We need to migrate to mysql2 asap.

geclos avatar Mar 25 '24 00:03 geclos

@geclos if this could be useful somehow, I have changed two items:

the package-lock.json in my latitude project directory from mysql to mysql2

[...]
"node_modules/@latitude-data/mysql-connector": {
      [...]
      "dependencies": {
        "@latitude-data/base-connector": "^1.1.0",
        "@latitude-data/query_result": "^0.2.0",
        "mysql2": "^3.9.2"
      }
    }
      [...]

and the my-latitude/node_modules/@latitude-data/mysql-connector/dist/index.js

import { createPool } from 'mysql2';

and it worked perfectly.

cdaraujo1 avatar May 03 '24 13:05 cdaraujo1

Yup that's essentially what we need to do here, we just haven't had the bandwith yet. I'll try to squeeze it next week. PRs are also welcome if you feel adventurous.

geclos avatar May 03 '24 19:05 geclos

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Jun 15 '24 01:06 github-actions[bot]