jwcrypto
jwcrypto copied to clipboard
chore(quality): add quality tools
trafficstars
Description
This PR intends to add quality tools (flake8, black, pyupgrade, mypy), locally using pre-commit and in the CI.
Technical details
- Add
flake8and run the tool on the codebase - Add
blackand run the tool on the codebase - Add
pyupgradeand run the tool on the codebase - Add
mypyand run the tool on the codebase
TODO
- [ ] Add related documentation in README
- [ ] Add CI checks
- [ ] Finish
mypyintegration - [ ] Add
isort - [ ] Add
check-yaml
Future work
- With
mypyrunning on the codebase, addpy.typedmarker so that library usage of external projects can also be type-checked.
Looks like this PR is making a massive amount of trivial changes. Can you please match the ignores already present in tox.ini ?
I am all for more linters, but I am not going to accept massive changes where all that changes is the type of python quoting used or similar changes, the code base is to big and mature for that kind of change, it would clobber history (git blame) for no good reason.
Agreed, I'll proceed to changes and ping you once this PR is ready to be reviewed :+1: