lat9

Results 170 comments of lat9

> One PR per file? That would be good. > So currently our testsuite doesn't test against PHP8.2 We could run tests, but not make them obligatory given 8.2 is...

> Is this a mindless task. Is it sufficient to add var property for the list of errors. for example, object_info.php add > > ``` > var $configuration_id, > $configuration_title,...

@brittainmark, thanks for doing this. It'll be a super-big help to understand when we're finished!

Be very careful when a class (e.g. order.php) uses notifications. For those classes, I'll suggest that all variables be defined as `public`; otherwise, existing observers that might be interrogating/updating those...

> > How when the currency only has 2 significant figures can the product's price honestly be something other than a value that has the same number of significant figures...

Bumping this. Do I need to unset the $languageLoader for SuperGlobals to interoperate with zc158?

Also the /images/banners/think_anim.gif: ![image](https://user-images.githubusercontent.com/2685585/175811280-ea68e269-4fbf-4550-ad08-e2d424c22e64.png)

Could it have anything to do with the keep-alive timer? Just throwing that out there.

> Please PR here: https://github.com/lat9/display_logs Let Cindy take care of the versioning. Urm, no. Since "Display Logs" is now in the core, the change should be addressed in the core.