Jordan Last

Results 175 comments of Jordan Last

I've started working on this, considering two traits `IntoJsValue` and `FromJsValue`.

Don't we want to implement the `From` or `From` trait for `JsValue`? Why aren't we adding an implementation in here: https://github.com/boa-dev/boa/blob/main/boa_engine/src/value/conversions.rs? I would like to be able to do the...

What can we do to move this forward? I am currently in need of this now and it would be nice to get back on the main branch of Boa.

Awesome, I will experiment with that next, thanks!

I'm ready to tackle this, can you show me some code for what is currently possible converting a `Vec` into a `JsUint8Array` and vice versa? If it isn't currently possible...

I've attempted to follow your guidance here but run into a major problem early on. Here's what I'm trying to add to https://github.com/boa-dev/boa/blob/main/boa_engine/src/object/jstypedarray.rs: ```rust impl From for $name { #[inline]...

I haven't tested it yet, our solution is still a bit hacky. But this looks like it would probably solve the problem. I plan to incorporate this eventually.

I believe there's an open pull request for this: https://github.com/boa-dev/boa/pull/1971

I believe this library is broken because of this issue: https://github.com/emn178/js-sha256 This is a pretty scary issue for our users, as any library could appear to function properly (no errors)...

The code for js-sha256 works fine in V8 (Node.js). The bugs found in this issue with the libraries I've tested have never presented in V8 (Node.js) during my testing. I'm...