mcp-agent icon indicating copy to clipboard operation
mcp-agent copied to clipboard

Fix AnthropicAugmentedLLM max iteration scenario

Open StreetLamb opened this issue 11 months ago β€’ 1 comments

Previously, when max iteration occurs, response.stop_reason was wrongly referencing the list tool result.

StreetLamb avatar May 18 '25 08:05 StreetLamb

@StreetLamb needs conflict resolution but approving the PR so you can merge in when you get the chance

saqadri avatar May 28 '25 15:05 saqadri

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes update variable names in the AnthropicAugmentedLLM class's generate method for clarity and correctness. The result of self.agent.list_tools() is now stored in list_tools_result instead of response, and a stopping condition check now references the correct response object from the responses list.

Changes

File(s) Change Summary
src/mcp_agent/workflows/llm/augmented_llm_anthropic.py Renamed variables for clarity in generate; improved stopping condition logic to use correct response object.

Poem

A hop and a skip through the code we go,
With names now clear, our logic in tow.
No more confusion, the path is brightβ€”
Each response in order, everything right.
The rabbit approves, with a twitch of the nose,
Onward through workflows, as clarity grows! πŸ‡βœ¨


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 7f0044f0377189e027f42dd766ba5a2fb086ac9d and 88d90dad7a0177629ba78ac2573e5ec7a39bbbbc.

β›” Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
πŸ“’ Files selected for processing (1)
  • src/mcp_agent/workflows/llm/augmented_llm_anthropic.py (2 hunks)
✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 12 '25 15:06 coderabbitai[bot]