Andras Lasso comments

Results 869 comments of


                                            Andras Lasso

MedSAM plugin s4ext file added

We'll review this after finishing up: * https://github.com/Slicer/ExtensionsIndex/pull/2092

After closing the window, an exception was raised at the return error: 0x000007FFAB9F1FB1D (Qt5Guid. dll) (located in Main.exe): 0xC000000 5: Access conflict occurred while reading position 0xFFFFFFFFFFFF.

I would recommend to run this code snippet in debug mode and have a look at the call stack.

After closing the window, an exception was raised at the return error: 0x000007FFAB9F1FB1D (Qt5Guid. dll) (located in Main.exe): 0xC000000 5: Access conflict occurred while reading position 0xFFFFFFFFFFFF.

Sorry, I won't be able to help with this. I don't use CTK plugin framework and the error seems to be in some basic Qt widget classes.

ITK's SpatialOrientation and OrientImageFilter have opposite definitions of the DICOM standard

I've found the old names very confusing, so this change is very welcome. To reduce the scope of the change, we could keep the current filters and just add new...

ITK's SpatialOrientation and OrientImageFilter have opposite definitions of the DICOM standard

When string code is get/set with the new methods like `Get/SetDICOMOrientation(string code)` then the DICOM definition is used. Having the old deprecated methods and enum values is less clean now....

ITK's SpatialOrientation and OrientImageFilter have opposite definitions of the DICOM standard

The proposed implementation looks good to me. It is clean and transition should not be difficult. Maybe `DICOMOrientImageFilter` name could a bit more generic, to allow it to be used...

ITK's SpatialOrientation and OrientImageFilter have opposite definitions of the DICOM standard

> Please don't remove itkSpatial classes and OrientImageFilter, just add new enums with clear names, both "from" and "to", it is easy. I agree - when nothing is broken, no...

Add SlicerSegmentationExport extension

The extension description file must have .json extension. The repository name string has a typo (has an extra space). These need to be fixed to be able to run the...

MedSAM Segmentation Extension

Thanks a lot for your contribution! This is very close to be ready to be added to the extensions index, there are just a few items to address: - [...

MedSAM Segmentation Extension

@rasakereh Let us know if you want to proceed with merging the pull request and addressing the few remaining minor points. We could make the extension available by pointing the...