SlicerSegmentEditorExtraEffects icon indicating copy to clipboard operation
SlicerSegmentEditorExtraEffects copied to clipboard

Published 20 hours ago • verified publisher icon lassoan

ENH: Allow disabling histogram (2D views) interactions for LocalThreshold

Open mauigna06 opened this issue 1 year ago • 1 comments

mauigna06 avatar Apr 03 '24 20:04 mauigna06

Can you describe why this is needed? I suspect that there could be better ways to achieve what you want without introducing this change.

We have a qSlicerMarkupsPlaceWidget to put one point over the 2D slices, its position is used for the localThreshold seed and minimum threshold value (and the maximum threshold value is set to the upper scalar range of the CT), we consider the histogram interaction undesired and incompatible with our current workflow :)

mauigna06 avatar Apr 05 '24 17:04 mauigna06

@lassoan could this be merged? I think I completed your requirements

Thanks a lot! :)

mauigna06 avatar Jun 13 '24 19:06 mauigna06

This is no longer needed, as view interactions can be disabled in the base class, by setting effect.enableViewInteractions=False - see:

https://github.com/Slicer/Slicer/blob/dc97ab25ebc1c595fc74cac4cb6ad93dfc894d58/Modules/Loadable/Segmentations/EditorEffects/Python/SegmentEditorEffects/SegmentEditorThresholdEffect.py#L747

lassoan avatar Jun 14 '24 15:06 lassoan