gretel icon indicating copy to clipboard operation
gretel copied to clipboard

Support bootstrap4

Open 44uk opened this issue 8 years ago • 11 comments

Add class for fragment and bootstrap4 style.

44uk avatar Jul 11 '16 11:07 44uk

Failing Travis CI by Rails 4.x on Ruby 1.9.3, what should I do for all green?

44uk avatar Jul 13 '16 04:07 44uk

+1

MrShemek avatar Dec 07 '16 22:12 MrShemek

+1

I also need this feature for spectre.css. It has the same syntax with Bootstrap 4.

<ul class="breadcrumb">
  <li class="breadcrumb-item">
    <a href="#">
      Home
    </a>
  </li>
  <li class="breadcrumb-item">
    <a href="#">
      Profile
    </a>
  </li>
  <li class="breadcrumb-item">
    Change avatar
  </li>
</ul>

ref.) https://picturepan2.github.io/spectre/components.html#navigation

h6ah4i avatar May 11 '17 09:05 h6ah4i

What we really need may be supporting fragment class.

44uk avatar May 11 '17 10:05 44uk

Hi!

@WilHall as Ruby 2.0 support has ended we should probably remove it from Travis CI. Could you please do that so @44uk 's tests can pass ?

@WilHall could you please merge it afterwards ? We love Gretel and being able to upgrade to Bootstrap 4 beta 1 with it would be appreciated 👍

czj avatar Aug 18 '17 12:08 czj

bootstrap v4.0.0-beta had been released. but no need to change. https://getbootstrap.com/docs/4.0/components/breadcrumb/

44uk avatar Aug 21 '17 17:08 44uk

@44uk since this repo is not maintained anymore can you submit this PR into https://github.com/WilHall/gretel (soon-to-be) active fork?

mkasztelnik avatar Nov 09 '18 06:11 mkasztelnik

@mkasztelnik Thank you for the advice. I'll check updated bootstrap(Currently v4.1.3 released) and do PR to the fork.

44uk avatar Nov 09 '18 07:11 44uk

@mkasztelnik thank you for your work.

Will https://github.com/WilHall/gretel be the repo from which the gem is built from now on ?

czj avatar Nov 09 '18 08:11 czj

@czj yes, together with @WilHall we are going to maintain the gem again.

MrShemek avatar Nov 09 '18 08:11 MrShemek

Awesome @MrShemek :-) We'll gladly help if we can @levups

czj avatar Nov 09 '18 09:11 czj