dish icon indicating copy to clipboard operation
dish copied to clipboard

Published 20 hours ago • verified publisher icon lassebunk

Reason for implementing 'to_json'

Open MarkusHarmsen opened this issue 10 years ago • 2 comments

Why has the Dish::Plate#to_json method been merged into 99ac61a0d76c52bfdf10ff41e5a4bccf80aa76bd?

It is quite complex and even contains platform specific dependencies (NSJSONSerialization). So let the user decide how he/she wants to use to_json. Any thoughts?

Furthermore it's not covered by any tests.

MarkusHarmsen avatar Oct 22 '14 16:10 MarkusHarmsen

I removed the to_json method and did some cleanup in my fork. See: https://github.com/MarkusHarmsen/dish/compare/lassebunk:master...master I could create a pull request if desired ;)

MarkusHarmsen avatar Oct 22 '14 18:10 MarkusHarmsen

I share your concerns. I'll work on this. Thanks.

lassebunk avatar Oct 22 '14 18:10 lassebunk