space_packet_parser icon indicating copy to clipboard operation
space_packet_parser copied to clipboard

Add spp.create_packet_list function

Open medley56 opened this issue 9 months ago • 1 comments

Checklist

  • [x] Changes are fully implemented without dangling issues or TODO items
  • [x] Deprecated/superseded code is removed or marked with deprecation warning
  • [x] Current dependencies have been properly specified and old dependencies removed
  • [x] New code/functionality has accompanying tests and any old tests have been updated to match any new assumptions
  • [x] The changelog.md has been updated

medley56 avatar Mar 08 '25 00:03 medley56

Codecov Report

:x: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 93.49%. Comparing base (7d9468a) to head (b0ab4b6). :warning: Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
space_packet_parser/xarr.py 93.75% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   93.43%   93.49%   +0.05%     
==========================================
  Files          37       37              
  Lines        2605     2627      +22     
==========================================
+ Hits         2434     2456      +22     
  Misses        171      171              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 08 '25 03:03 codecov[bot]

I'm going to decline this PR. I don't think this intermediate abstraction is needed to save users from having to type packet_list = list(generator)

medley56 avatar Aug 04 '25 14:08 medley56