Luis Martinez

Results 117 comments of Luis Martinez

I was thinking about trying to locate the ``required_conan_version`` "manually" only after getting an `ImportError` (to improve the error message if we locate the required_conan_version, or keep raising otherwise)

> What is the "None" doing there? There is a bug in the `CMakeToolchain`, if the "res" is not set it shouldn't adjust the `CMAKE_INSTALL_DATAROOTDIR`. > It is not clear...

Hi, I made a small tests to try to reproduce the issue installing the license but I cannot reproduce it, here is the test: ```python def test_resdirs_cmake_install(): client = TestClient(path_with_spaces=False)...

@paulharris Sorry for the delay. I'm able to reproduce it. The issue comes from not declaring `resdirs`, causing the `CMakeToolchain` to not set the `CMAKE_INSTALL_DATAROOTDIR`. If the `CMakeLists.txt` contains something...

We have been reviewing this. As I said, we only adjust `CMAKE_INSTALL_DATAROOTDIR` when there is a `resdir` defined, otherwise the variable is not filled. That variable should/might have a default...

Hi! This is a duplicate of https://github.com/conan-io/conan/issues/11743 that has been merged to be released at `1.51.1` but we still have one more regression pending on CMakeDeps so we are working...

Simple example doing a bit of inheriting and variables declaring (already working): **profile_vars** at `~/.conan2/profiles/profile_vars`: ```jinja2 {% set bar = "Bar-baridad" %} ``` **foo** at `~/.conan2/profiles/foo`: ```jinja2 {% import "profile_vars"...

We want only one way to do things and jinja does it perfectly. It doesn't make any sense to keep the support for a custom one. That is one big...

Before introducing the `CMakePresets` in conan, the toolchain used a file named `conanbuild.conf` to write all the information, (that shouldn't or can't belong to the toolchain itself), that the `CMake`...

This is weird, we have several tests using Windows + Ninja generator, and one of them is explicitly checking that the generator in the `CMakePresets.json` is `Ninja`. Could you attach...