Lasse Jørgensen

Results 175 comments of Lasse Jørgensen

@imonish8 The issue has not been triaged yet so I would wait. My issue is not with the use of a progress bar but what an animated progress bar represents...

Just to be clear, this is also based on user feedback. The user thought the page was stuck loading. Not saying that the feedback from a single user is a...

I haven't looked at the full process (it is a bit convoluted to trace) but I was kind of under the impression that we constructed the content of the head....

Why do we assume the link element is in the correct location? Why is the link element location, or the parent node, relevant to the injected styles location? Shouldn't the...

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link Permitted parents | Any element that accepts metadata elements. If [itemprop](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/itemprop) is present: any element that accepts [phrasing content](https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#phrasing_content). -- | -- A <link> element can occur either in...

I just move the objects out of the component. If they need props at some point we can just move them back inside.

Doesn't the text need to be translatable? Do they use the `t` function with the text? Pretty annoying function name BTW, good luck doing a search for that identifier in...

Well, it was just an example. But I do think it communicates its purpose a bit better. Just to be clear, I would still suggest we add the text. We...

No, onboarding shouldn't be required to understand what the main buttons do. But it's also not uncommon to have an onboarding step that quickly goes through the UI. Lots of...

I think both should be updated. Half the text in that step is about something unrelated to Schema and Schema types, it barely even explains what they are and how...