Lasse Jørgensen
Lasse Jørgensen
I'm not really sure why we use stringify on the parameter. But when I was removing it didn't seem to change anything. What seems odd is when I do a...
I haven't checked, but are we sure `.progress-bar-percent` isn't used elsewhere? I'm not saying the linear-gradient with the animation is working well if it is used elsewhere, but changing it...
If we remove the gradient, I don't think we need the animation as well. --- We didn't get any feedback yet in the issue from one of the maintainers, and...
BTW, how does it look with the paragraph element? I didn't check, but I would assume the element needs some styles to be larger and have more weight?
I wouldn't mind it if it only affected pre-made setups but I do mind it when I clone down a repo and it changes my theme. For people who often...
My vote would be yes, at least for the repos. If the theme can be implemented as part of a Gitpod task/config as suggested, that would be fine. I don't...
I think we should allow for both a concise body and an expression body for the callback function. That is, make the curly braces optional. ```js checkpoints.forEach((checkpoint) => checkpoint.draw()) ```
You can try a rebase with `main` to see if that fixes the test issues. If it doesn't you might have to wait until someone who knows why the tests...
It should pass at least, but yes I do think it is more readable as well. I would still propose that using a regex for this requirement is not going...
I'm all for expanding this with some more steps. We might be able to combine some of the suggested steps you have but it is hard to know without seeing...