Lasse Jørgensen

Results 175 comments of Lasse Jørgensen

We might want to hold off on this until there is an agreement found on the issue. I would prefer if we fixed the challenge text but I also wouldn't...

I guess you are right. ``` const location = 'https://example.com'; ``` How is a const declaration inside the editor overwriting the global object?

Seems unexpected. A variable declared using const should not be able to overwrite global objects. I would consider that a bug, not a quirk. It should either be a syntax...

Updated the title and initial post and added yet another instance of this happening. I can guarantee it will keep happening as people missing the "s" at the end of...

I'm all for dropping browsers that do not support `const` and `let`. Also, don't we already use other JS that wouldn't be supported by those browsers? Like optional chaining and...

> We also use Babel to transpile the tests before running them. I guess we didn't used to do that? I swear we had an issue with optional chaining at...

I'm surprised we use such an old target for the transpilation. I thought we generally didn't support unmaintained operating systems, devices, and browsers.

@ojeytonwilliams is there any issue with updating the target as you suggested? If not I would suggest we do so.

Do we even need regex here? I think something like this should work the same in all browsers but I only tested it in Chrome and Firefox. ``` const button...

Not sure I understand why we care if there is a new line. If this requirement is meant as a code formatting requirement we shouldn't allow the use of `\n`...