simple_oauth icon indicating copy to clipboard operation
simple_oauth copied to clipboard

Published 20 hours ago • verified publisher icon laserlemon

Add support for HMAC-SHA256 signature method

Open pritambios opened this issue 4 years ago • 2 comments

pritambios avatar Jul 13 '20 08:07 pritambios

Coverage Status

Coverage remained the same at 100.0% when pulling 17908bfd5f7027cdd6fe820967930061945e0643 on pritambios:feature/support_sha256_encription into 4a375da4e213667e356e98a9e2bc3c3b8b969d67 on laserlemon:master.

coveralls avatar Jul 13 '20 08:07 coveralls

Hi @laserlemon @sferik , we need HMAC-SHA256 encoding to be supported by simple_oauth. Our rails app is depended on https://github.com/instructure/ims-lti gem. We have received an error from ims-lti gem. And figured out that simple-oauth isn't supporting hmac-sha256.

NoMethodError: undefined method `hmac_sha256_signature' for #<SimpleOAuth::Header:0x00007f5130bab610> Did you mean? hmac_sha1_signature

Please let me know if I need to update anything in this PR.

pritambios avatar Jul 14 '20 06:07 pritambios