figaro icon indicating copy to clipboard operation
figaro copied to clipboard

Change exist method for gitignore

Open muhenge opened this issue 2 years ago • 7 comments

-Fix typo in the ignore_configuration method

This pull request fixes a typo in the ignore_configuration method of the project's codebase. The current implementation uses File.exists? to check if a .gitignore file exists, which should be replaced with File.exist? for consistency with Ruby's standard library.

I have tested this change on my local machine and confirmed that it resolves the issue.

muhenge avatar Feb 23 '23 16:02 muhenge

This would fix on new versions but maybe crash on older versions, i think you should check the RUBY_VERSION, because old ruby versions still use .exists?

joao-saraiva avatar May 07 '23 13:05 joao-saraiva

Any chance of this being merged soon? Have to work with a fork otherwise.

Thanks :)

DavidAmyot avatar Jul 28 '23 14:07 DavidAmyot

A merge would be quite nice

CuddlyBunion341 avatar Aug 21 '23 16:08 CuddlyBunion341

I think this should already be merged, I almost wanted to create a new PR for the same Issue, can someone please merge this PR thanks :)

cooljl31 avatar Sep 23 '23 10:09 cooljl31

This would fix on new versions but maybe crash on older versions, i think you should check the RUBY_VERSION, because old ruby versions still use .exists?

The "exist?" method is also valid for old Ruby versions. The repository is using it in some files. Can someone with access merge this PR to solve the issue?

cc @laserlemon.

lucasfontes2604 avatar Apr 11 '24 14:04 lucasfontes2604

I believe the new alternative in 7+ is Pathname.new(path_name).exist?

Jberma23 avatar May 22 '24 22:05 Jberma23