figaro icon indicating copy to clipboard operation
figaro copied to clipboard

Already check entry in .gitignore for application.yml

Open tannakartikey opened this issue 8 years ago • 4 comments
trafficstars

Currently, even if the application.yml is ignored using .gitignore file, on running bundle exec figaro install, the entry is appended again.

The entry can be present already if you are not the only one in the team and someone started using Figaro before you.

tannakartikey avatar Feb 10 '17 16:02 tannakartikey

I looked into this and found that if you have

# Ignore application configuration
/config/application.yml

in your .gitignore, nothing will be appended. However, if you removed either of the two lines, it will append both lines and make the file redundant.

It seems that figaro should really only care about /config/application.yml. I'll put in a PR for this fix.

JStans12 avatar Feb 22 '17 19:02 JStans12

We shouldn't hardcode the path also. So it should just care about application.yml

tannakartikey avatar Feb 22 '17 19:02 tannakartikey

@laserlemon your views?

tannakartikey avatar Mar 31 '17 01:03 tannakartikey

As of today, we should hardcore the path because that's exactly where Figaro will look for it. Thank you for checking on this!

laserlemon avatar Mar 31 '17 10:03 laserlemon