figaro icon indicating copy to clipboard operation
figaro copied to clipboard

Published 20 hours ago • verified publisher icon laserlemon

Elastic Beanstalk Support

Open fny opened this issue 9 years ago • 11 comments

This commit adds AWS Elastic Beanstalk support through figaro eb:set. All of the related option accoutrements are included too.

I also extracted the command-related expectations into an expect_ran helper to DRY things up a bit.

Growing Plant

Fixes #193. Passing version of #187. :bowtie:

fny avatar May 09 '15 01:05 fny

Not sure what's up, but there's a test from something outside the scope of my changes that's failing on the latest build (weirdly 264.11 alone). Everything was passing the first time I made this PR (Build 263). :confused:

fny avatar May 15 '15 04:05 fny

@fny any luck in making this test pass?

BilalBudhani avatar May 26 '15 11:05 BilalBudhani

Yes, but I cheated. I just pushed a change to the README, and all is well.

It looks like there's a bug elsewhere Figaro that makes that spec randomly fail on Ruby 1.9.3 and Rails 3.2: See #200.

fny avatar May 26 '15 17:05 fny

Would love to see this merged!

hiattp avatar Aug 12 '15 07:08 hiattp

Is this still waiting on merge conflicts to be resolved?

guirl avatar Oct 02 '15 19:10 guirl

No. @laserlemon just seems uninterested in this feature. There were no conflicts when this PR was originally made, it's just been sitting around for awhile.

fny avatar Oct 02 '15 19:10 fny

Any updates on this?

Haar avatar Dec 09 '15 15:12 Haar

@laserlemon think this is still mergeable?

jbhatab avatar Jun 21 '16 08:06 jbhatab

Coverage Status

Changes Unknown when pulling 4c2a9a89a3b94c0b0841d8f8728173c960d18324 on fny:elastic-beanstalk-support into ** on laserlemon:master**.

coveralls avatar Jan 13 '17 09:01 coveralls

@laserlemon Um..why hasnt this been merged already?

bjensen avatar Apr 12 '17 10:04 bjensen

It would be great to see this merged. 👍

taranda avatar Sep 28 '17 19:09 taranda