gnome-shell-extension-suspend-button icon indicating copy to clipboard operation
gnome-shell-extension-suspend-button copied to clipboard

No icon displayed

Open sabian2008 opened this issue 7 years ago • 9 comments

Hi

I'm in a fresh Fedora 27 installation (Gnome 3.26) and, although the extension works fine, it only adds an empty space (which is clickable and it works!) to the menu.

Any ideas on where to start looking for errors?

Cheers,

sabian2008 avatar Oct 22 '17 14:10 sabian2008

It's because of the last update. Find the following line on extension.js:

this._altsuspendAction = this.systemMenu._createActionButton('system-suspend-symbolic', _("Suspend"));

and replace it with:

this._altsuspendAction = this.systemMenu._createActionButton('media-playback-pause-symbolic', _("Suspend"));

This is happening because not all icon packs provide 'system-suspend-symbolic'

Naheel-Azawy avatar Oct 22 '17 15:10 Naheel-Azawy

Thanks a lot, worked like a charm.

Really nice extension, it's a must (and I use very few extensions!).

Cheers,

sabian2008 avatar Oct 22 '17 22:10 sabian2008

Perhaps it would be best if the icon were configurable.

jackpot51 avatar Oct 23 '17 01:10 jackpot51

Or even better, automatically figure out which icon can be used. Too lazy to dig more in the gjs docs. Dev, can you please :)

Naheel-Azawy avatar Oct 23 '17 17:10 Naheel-Azawy

I think having system-suspend as default and the old one as fallback is a good solution. I will look into that.

laserb avatar Oct 23 '17 18:10 laserb

I changed it back to the old icon for now.

laserb avatar Oct 24 '17 03:10 laserb

About the system suspend as default: the new icon could be present but could have nothing to do with the style in the set that the shell theme is using (maybe due to icon-fallback?). In my case, while the old icon was totally consistent with the other icon used in the other buttons, the new one is not. That should be taken into consideration as well.

ddnexus avatar Oct 25 '17 04:10 ddnexus

@jackpot51

Perhaps it would be best if the icon were configurable.

I don't think this is useful.

genodeftest avatar Oct 26 '17 10:10 genodeftest

@genodeftest I don't mind it going back to the pause button if that fixes problems - I am using a fork with my preferred icon anyways

jackpot51 avatar Oct 26 '17 13:10 jackpot51