Alina Sharon

notes: on this commit https://github.com/KomodoPlatform/komodo-defi-framework/pull/2100/commits/495e7a9a059caec93ab009b36fbc5f9621582327 both send and spend erc721/erc1155 tests (use sepolia testnet) passed  starting from this commit https://github.com/KomodoPlatform/komodo-defi-framework/pull/2100/commits/e917b0b50544fa35310bc869c3defe7ee4f3ee1b komodefi app is able...

Seems like `wait_until: now_sec() + 70` is not enough for ERC-721 transactions. I will increase the wait time for confirmations. ```bash ---- docker_tests::eth_docker_tests::send_and_spend_erc721_maker_payment stdout ---- All pending transactions have been...

@mariocynicys > Q: Why are we replacing geth node tests with sepolia? At the beginning, we were using this [one etomic smart contract](https://github.com/KomodoPlatform/etomic-swap/pull/7/files#diff-4fbc70133f776a1b34e544ef41ef907e539274b313f82bf83c77e1f1bd916daa) version for NFT swaps, which supported both...

wip, as need some changes https://github.com/KomodoPlatform/komodo-defi-proxy/pull/22#issuecomment-2106158228

PS: if someone will have more notes, I would like to fix them in this PR https://github.com/KomodoPlatform/komodo-defi-framework/pull/2129 to avoid conflicts

> @laruh I guess I will have to review, approve and then merge this PR #2129 first and also this PR [KomodoPlatform/komodo-defi-proxy#22](https://github.com/KomodoPlatform/komodo-defi-proxy/pull/22) before merging this. Is that correct? @shamardy I...

reqs examples how to enable nft, with platform coin and separately ```json curl --url "http://127.0.0.1:7783" --data '{ "userpass": "'$USERPASS'", "method": "enable_eth_with_tokens", "mmrpc": "2.0", "params": { "ticker": "MATIC", "mm2": 1, "swap_contract_address":...

@shamardy thanks for pinging, will fix conflicts asap. i suppose they occurred after eth gas limit PR merge this night. > I guess NFT will still work if we don't...

Hi I was working on tx fees for NFTs and found that we dont do check for [eip-1559](https://eips.ethereum.org/EIPS/eip-1559) transactions when we save Eth history in database (despite the fact that...

If there is a connection problem during Zcoin activation, tonic just propagates [connection errors](https://pastebin.com/JBw66N0F) and doesn't try to reconnect, if connection is stabilized.