Alina Sharon

Results 22 comments of Alina Sharon

@dimxy please keep in mind, that PR started to have conflicts in `eth.rs`

ps @dimxy pr started to have conflicts

@dimxy note that PR started to have conflicts 👀

todo for NFT Wallet support: - [x] impl `withdraw_nft` - [x] impl erc1155 withdrawing - [x] impl erc721 withdrawing - [x] cover all EVM based protocols that we already support...

RnD for swaps: - one of the optional ways of solving problem of swaps and ordermatching is to add enable nft methods/add nft config/use `enable_eth_with_tokens` [comment](https://github.com/KomodoPlatform/atomicDEX-API/pull/1704#discussion_r1136114811) - it worth adding...

Necessary enhancements and todos for NFT SWAP part - [ ] Proxy-auth layer https://github.com/KomodoPlatform/komodo-defi-framework/pull/2100 https://github.com/KomodoPlatform/komodo-defi-proxy/pull/22 - [ ] NFT activation uses NFT conf from coin config file https://github.com/KomodoPlatform/komodo-defi-framework/pull/2129 - [x]...

@mariocynicys please merge dev to feature branch as it contains build fixes https://github.com/KomodoPlatform/komodo-defi-framework/actions/runs/8965111556/job/24617995991?pr=2109#step:8:574 ``` error[E0463]: can't find crate for `core` | = note: the `x86_64-apple-darwin` target may not be installed...

ps @mariocynicys this pr started to have conflicts