Eric Larson

Results 1455 comments of Eric Larson

... the other advantage of spltting in this way is things like `picks="eeg", exclude=...` can work and we don't have to implement stuff like `"good eeg"` and `"all eeg"` etc.

> I think we actually used to exclude all bads when picks=None. When did this change? At least from a few years back when we added `picks=` support I think...

>> on the assumption that we actually have an exclude param in all the relevant places (I think we do but haven't checked). And even if not, it feels cleaner...

I think the indentation on `main` is correct... see for example pre-commit.ci complaining about this change. Contents of `try` blocks should be indented more than the `try` itself

FYI PyTables cut a release that should be NumPy 2.0 compatible hopefully https://github.com/PyTables/PyTables/releases/tag/v3.10.1

Ugh yes this looks like a bug. Would you be up for trying a fix? If not I can look hopefully soon. Would also be good to trim this down...

Maybe we just need to change the check to: ``` if getattr(self, "annotations", None) is not None: ```

Yes PR welcome! Not sure about whether or not the system should have a meas date for the helium info. It's also possible it was never supposed to have it....

@SophieHerbst I looked into this briefly and I think this is probably already fixed in `main`, but I tacked on a little test to https://github.com/mne-tools/mne-python/pull/13310 and helped ensure things should...

Yeah that probably is too narrow. It would probably be an annoying deprecation but probably worth it. I think so far I always set it to something else because the...