crashdumper icon indicating copy to clipboard operation
crashdumper copied to clipboard

Published 20 hours ago • verified publisher icon larsiusprime

Fix getFolderPath of HookOpenFL for mobile build

Open andiccml opened this issue 7 years ago • 3 comments
trafficstars

Function getFolderPath have some wrong function signatures in mobile branch.

When building from master (Haxe 3.4.7 / OpenFL 8.6.4 / Lime 7.1.1 / Windows 10) for android, it gives me the following error:

2018-10-29

I fixed it using the other case in the same line then it gives me the following:

2018-10-29 1

The changes in this PR fixes these issues and the build goes fine!

andiccml avatar Oct 29 '18 19:10 andiccml

Since you're using the #mobile pathway, have you tested it for iOS as well as android?

larsiusprime avatar Oct 29 '18 19:10 larsiusprime

No, I didn't. Sorry. I'm able to run test ios on Windows successfully (it generates the xcodeproj files), but since I don't have a Mac, I'm not able to complete the build process.

Since this is a compile time error, I believe the fix should work for iOS too (or, in another way, the error without the fix should occur for iOS too).

andiccml avatar Oct 30 '18 00:10 andiccml

No problem, I'll probably merge this tomorrow then. (I'm not easily able to test on iOS either). If it's broken on iOS, presumably someone will tell us!

larsiusprime avatar Oct 30 '18 04:10 larsiusprime