abapOpenChecks icon indicating copy to clipboard operation
abapOpenChecks copied to clipboard

Fake package encapsulation

Open larshp opened this issue 6 years ago • 7 comments

Fake package encapsulation

  • Database table to structure or data element
  • Data element to domain
  • Class to interface
  • Code to message class
  • etc.

Configuration:

  • List of packages
  • Checkbox to allow references to SAP standard objects

is it possible to call some standard functionality?

larshp avatar Mar 22 '18 13:03 larshp

https://github.com/larshp/abapOpenChecks/blob/master/src/checks/zcl_aoc_check_61.clas.abap

larshp avatar Mar 31 '18 10:03 larshp

SELF_CONTAINED SELF_CONTAINED_ALLOW_STANDARD NO_REFERENCES_IN NO_REFERENCES_OUT

larshp avatar Jun 17 '18 16:06 larshp

branch https://github.com/larshp/abapOpenChecks/tree/fake

larshp avatar Jul 11 '18 05:07 larshp

@larshp, I was trying to find out what the purpose of the characteristics ZAOC_ENCAPSULATION, ZAOC_ENCAPSULATION_OBJECTS and ZAOC_ENCAPSULATION_PACKAGES is. It looks like it was in preparation for this check (CHECK_61), right?

Can you please elaborate on the status of the implementation? The documentation only says work in progress and todo.

I have not worked with object characteristics before, which is why I am curious about this. The idea looks interesting, maybe I can support.

ConjuringCoffee avatar Aug 03 '23 10:08 ConjuringCoffee

the standard package interfaces is a mess IMHO, so this was one take to try to fix it

however, I dont think its relevant anymore, as its easy to enforce and check any set of encapsulation with abaplint

larshp avatar Aug 04 '23 05:08 larshp

I believe the functionality is still relevant. 😊 A check like this would enable to check encapsulation even if the system isn't fully working with abapGit / abapLint. (Ours certainly isn't yet...)

I'm imagining checks for:

  • Is this object used by another object that isn't allowed to?
  • Is this object using any objects it isn't allowed to?

ConjuringCoffee avatar Aug 04 '23 08:08 ConjuringCoffee

well, I choose to spend my time on getting abapGit / abaplint working

I guess characteristics are not released in Steampunk, so its a lost cause anyhow, looking long term

larshp avatar Aug 04 '23 09:08 larshp