Lars Eggert

Results 544 comments of Lars Eggert

> Do we not have tests for this? Should we? There are tests in #2128, but this PR alone doesn't make them succeed yet.

@mxinden anything left to be done for this one?

All true, but in practice, the local interface is most often the limiting hop.

This PR exposed a bug in `mtu` 🫤 https://github.com/mozilla/mtu/pull/26

> > > > Should we also optimistically start the search at the interface MTU > > Let me make sure I understand the implications here correctly. Sorry for any...

Yes. I _think_ this is a rare case, but maybe we add some telemetry first to confirm? We could also cache a probed MTU towards a destination IP, like the...

I was thinking we just log the log the local interface MTU together with the discovered PMTUD, and check for differences.

We need to bump the [`rayon` crate in mozilla-central](https://searchfox.org/mozilla-central/source/Cargo.lock#5149-5157) to `1.7`, which is what `windows-bindgen` requires, before we can land this PR and bring in `mtu` as a dependency. (See...

> @larseggert I can create a mozilla-central Phabricator patch if you want. In case there aren't any hidden issues, the only real work will be auditing `rayon` `v1.6.1 -> v1.7.0`...

Thanks, saw it. Trying to make `mtu` importable.