pdp10-its-disassembler icon indicating copy to clipboard operation
pdp10-its-disassembler copied to clipboard

Read saveset name from the right place

Open bictorv opened this issue 1 year ago • 3 comments

Support DUMPER format 6, which has saveset name at different offset. Also check dumper tape format and reject too old or invalid format codes.

This lets this program display the right saveset name for more tapes e.g. in http://www.bitsavers.org/bits/DEC/pdp10/magtape/dec_distribs/TOPS-20/.

bictorv avatar Jun 10 '24 11:06 bictorv

Format 0 has a different header, as far as I can tell. See TOPS-20 v4 DUMPER for some ways of handling it (there it is called TENEX/BBN format). Here, you should probably do the same check as at SETHDR there, to see if it is ASCII directly in the format field (rather than a format code). But I guess there are more differences - does dumper.c handle TENEX dumper files as it is now?

Can you point at some tape file in that format?

bictorv avatar Jun 14 '24 12:06 bictorv

My main purpose for writing this dumper.c was to create TENEX mini-dumper files. I don't have any tape samples from a real TENEX system. I have been testing the output from my program against MINI-DUMPER running on TENEX, and it seemed to work. You could of course create some tape files with dumper.c but I can't guarantee they are 100% correct.

larsbrinkhoff avatar Jun 15 '24 07:06 larsbrinkhoff

Sorry, I left some outstanding comments here that were never resolved, and then I forgot about this. E.g. format "0" very much is supported so the check for < 4 isn't appropriate. I made another change that should fix reading the saveset name for versions 5-6.

larsbrinkhoff avatar Jan 22 '25 11:01 larsbrinkhoff

I have now merged another pull request which I believes fixes the saveset name, whilst also retaining "format 0".

larsbrinkhoff avatar Jun 27 '25 07:06 larsbrinkhoff