upgrader icon indicating copy to clipboard operation
upgrader copied to clipboard

Published 20 hours ago • verified publisher icon larryaasen

Support to different release notes languages

Open humanolaranja opened this issue 2 years ago • 4 comments

Today we can provide the country code that makes ios release notes be translated if it have translation in the store of this country. But in Android we don't have this translation available, it's always the english one. I see that google play have the &hl=:country param to specify the country, so it's possible to use this param to get release notes translations. I see that the google play parser uses the keyword "What's new" to get the release notes, maybe we can find a way to change it and use the hl param for Android just like the countryCode for iOS

humanolaranja avatar Jul 15 '22 14:07 humanolaranja

If you agree with this @larryaasen you can assign this issue to me and I develop this feature and open a PR

humanolaranja avatar Jul 15 '22 14:07 humanolaranja

@humanolaranja Feel free to open a PR for this and I will review it. Thanks.

larryaasen avatar Jul 18 '22 01:07 larryaasen

Just created the #217 PR to solve this

humanolaranja avatar Sep 14 '22 12:09 humanolaranja

@larryaasen

humanolaranja avatar Sep 15 '22 12:09 humanolaranja

@larryaasen ?

humanolaranja avatar Sep 26 '22 14:09 humanolaranja

@larryaasen

humanolaranja avatar Oct 05 '22 13:10 humanolaranja

Since the PR with this feature was merged, can we have a new release with this and close this issue @larryaasen ?

humanolaranja avatar Oct 13 '22 19:10 humanolaranja

@larryaasen ?

humanolaranja avatar Oct 17 '22 15:10 humanolaranja

I see that 4.8.0 was released, closing the issue

humanolaranja avatar Oct 17 '22 15:10 humanolaranja

I found a bug in this, maybe some merge problem Opening #227 with the fix

humanolaranja avatar Oct 17 '22 18:10 humanolaranja

Fixed in 4.8.1

larryaasen avatar Oct 18 '22 12:10 larryaasen