Lee Rowlands comments

Results 46 comments of


                                            Lee Rowlands

[PROPOSAL] Make all loaders asynchronous-only and Promise-based.

When a template is loaded as a parent, the loader has to be able to operate in a sync fashion see this hunk in Twig.Template.prototype.render ``` if (!parentTemplate) { url...

[PROPOSAL] Make all loaders asynchronous-only and Promise-based.

Can do

Includes in Twig files throwing errors

FWIW, its a fresh rewrite rather than a fork. But I did try the other loader first.

Tagging different versions

+1 for tags please

[Bug]: @storybook/react-vite configuration for react-docgen doesn't support components that import postcss modules.

Thanks for getting back to me, appreciate it. > Your Stackblitz reproduction fails before it gets to this point, so I cannot verify the behavior. I hadn't saved the stackblitz,...

[Bug]: @storybook/react-vite configuration for react-docgen doesn't support components that import postcss modules.

Hey, is there any more information I can provide here?

[Bug]: @storybook/react-vite configuration for react-docgen doesn't support components that import postcss modules.

Thanks, I'm using the export unfortunately, to compile a separate CriticalCss component that imports the built stylesheet (with classes)

Use sqlite for simpletest

Didn't make huge speed difference for a single group so maybe we make it a flag?

Support some default block types

I strongly disagree with recommending paragraphs because of the N revisions issue. I think if we can't agree here we shouldn't chose either and wait for experience builder

Flog @dawehner's run tests on sqlite snippet

see #15