Daniel Espino García

Results 345 comments of Daniel Espino García

@sdomi Were you able to check also the server logs? Our server code should be able to handle the token coming from different places (not only from the cookie) so...

@sdomi looking a bit more into the code, I see that some logs get sanitized when the instance is not in developer mode, in particular the "detail_error" field you see...

@sdomi Thank you so much for helping into troubleshooting this bug!

After discussing with @enahum we are going to move forward with this change on the patch. That way, if something fails, the revert is way simpler. If we see this...

@yasserfaraazkhan The important part of this PR is to test changing between different kinds of connection (cell, wifi, vpn...) and see if the connection is restablished relatively fast.

@yasserfaraazkhan That is unexpected. @enahum I know you have been looking into SSL stuff. Any idea why this could happen?

@yasserfaraazkhan I am going to merge this, since the error you had seems unrelated. Worst case scenario, we can revert.

I created this other branch to get the builds: https://github.com/mattermost/mattermost-mobile/pull/8293 Heads up @Boruus that I merged main into your branch.

@Boruus It seems your changes are breaking one test. Could you take a look at it? I think some changes have to be made to keep the previous behavior (but...

@Boruus Another small thing. We simplified how things get imported, and that introduced some minor failures in your PR. The change you need to do is pretty simple. Just remove...